-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xargs: do not merge extra args before replacing #363
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 60.03% 60.48% +0.44%
==========================================
Files 32 32
Lines 4021 4069 +48
Branches 891 895 +4
==========================================
+ Hits 2414 2461 +47
Misses 1254 1254
- Partials 353 354 +1 ☔ View full report in Codecov by Sentry. |
458fab4
to
31a9c11
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@YDX-2147483647 sorry, i missed your question :( |
Never mind and thanks for your answer. So those 100+ lines is worth changing. I'll update the branch and add more tests when I have time. |
32986a8
to
4b3e4b9
Compare
Well, I've updated the branch. Could someone approve the CI? I think this PR is ready now. |
it it ready for review? :) |
Yes! It is ready. |
nice: |
Resolves #362
-I
/-i
/--replace
is given, now we process extra args (read from stdin) one by one, and replace all matches in initial args (given in argv) with the same extra arg in each time. (i.e. Cartesian product)-L
(--max-lines
),-n
(--max-args
) and-I
/-i
are mutually exclusive. Now we warn if more than one are given.