-
Notifications
You must be signed in to change notification settings - Fork 214
Provide uuid macro without dependencies #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, we should change the feature gate to something like "macro-diagnostics"
. I also personally think that it should be on by default and require opting-out, since nice error messages should be the default. Thoughts?
3497a03
to
9a18d3b
Compare
9a18d3b
to
205df6e
Compare
A [dependencies.uuid]
version = "1"
features = [
"v4", # allow generating random UUIDs
"fast-rng", # use a faster (but still sufficiently random) algorithm
"macro-diagnostics", # support more detailed diagnostics in the `uuid!` macro
] It's not on by default, but it's recommended by default. |
205df6e
to
6dfdade
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Nugine! This looks good to me. I just had one suggestion on a missed feature rename in the docs.
6dfdade
to
15ce218
Compare
I'm submitting a feature
Description
#556 (comment)
Related Issue(s)
resolves #556