Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Error type #373

Merged
merged 11 commits into from
Mar 17, 2019
Merged

Add Error type #373

merged 11 commits into from
Mar 17, 2019

Conversation

kinggoesgaming
Copy link
Member

@kinggoesgaming kinggoesgaming commented Mar 3, 2019 •
edited
Loading

I'm submitting a(n) feature

Description

Add uuid::Error that sums up uuid::BytesError and parser::ParseError

Motivation

Add a way for frameworks to not worry to handing both error types in uuid as separate types. Allows for exposing errors that don't explicitly matter until there is a need to handle them.

Tests

Related Issue(s)

N/A

@kinggoesgaming kinggoesgaming added this to the 0.7.3 milestone Mar 3, 2019
@kinggoesgaming kinggoesgaming self-assigned this Mar 3, 2019
@todo
Copy link

todo bot commented Mar 3, 2019

improve the doc

uuid/src/lib.rs

Lines 229 to 234 in 33c90d0

// TODO: improve the doc
#[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub enum Error {
/// An error occurred while handling [`Uuid`] bytes.
///
/// See [`BytesError`]

This comment was generated by todo based on a TODO comment in 33c90d0 in #373. cc @uuid-rs.

@kinggoesgaming kinggoesgaming requested a review from a team March 3, 2019 08:55
KodrAus
KodrAus reviewed Mar 4, 2019
View reviewed changes
src/lib.rs Show resolved Hide resolved
@kinggoesgaming kinggoesgaming marked this pull request as ready for review March 12, 2019 03:36
@kinggoesgaming
run fmt
630b06d 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
add Error to prelude attempt 2
886e07f 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Dylan-DPC-zz
Dylan-DPC-zz reviewed Mar 14, 2019
View reviewed changes
src/core_support.rs Show resolved Hide resolved
src/std_support.rs Show resolved Hide resolved
Dylan-DPC-zz
Dylan-DPC-zz previously approved these changes Mar 16, 2019
View reviewed changes
@kinggoesgaming
Copy link
Member Author

dont merge for now

@kinggoesgaming
Copy link
Member Author

have to add tests

@Dylan-DPC-zz Dylan-DPC-zz dismissed their stale review March 16, 2019 22:38

tests tests tests

@kinggoesgaming
add a TODO for Error tests
59962de 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@todo
Copy link

todo bot commented Mar 16, 2019

write tests for Error

not immediately blocking, but should be covered for 1.0

uuid/src/lib.rs

Lines 232 to 237 in 59962de

// TODO: write tests for Error
// BODY: not immediately blocking, but should be covered for 1.0
#[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub enum Error {
/// An error occurred while handling [`Uuid`] bytes.
///

This comment was generated by todo based on a TODO comment in 59962de in #373. cc @uuid-rs.

@Dylan-DPC-zz
Copy link
Member

bors: r+

bors bot added a commit that referenced this pull request Mar 16, 2019
@bors @kinggoesgaming
Merge #373
a412fdc 
373: Add Error type r=Dylan-DPC a=kinggoesgaming

**I'm submitting a(n)** feature

# Description
Add `uuid::Error` that sums up `uuid::BytesError` and `parser::ParseError`

# Motivation
Add a way for frameworks to not worry to handing both error types in `uuid` as separate types. Allows for exposing errors that don't explicitly matter until there is a need to handle them.

# Tests


# Related Issue(s)
N/A

Co-authored-by: Hunar Roop Kahlon <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 16, 2019

Build failed

@kinggoesgaming
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Mar 17, 2019
@bors @kinggoesgaming
Merge #373
4958abd 
373: Add Error type r=kinggoesgaming a=kinggoesgaming

**I'm submitting a(n)** feature

# Description
Add `uuid::Error` that sums up `uuid::BytesError` and `parser::ParseError`

# Motivation
Add a way for frameworks to not worry to handing both error types in `uuid` as separate types. Allows for exposing errors that don't explicitly matter until there is a need to handle them.

# Tests


# Related Issue(s)
N/A

Co-authored-by: Hunar Roop Kahlon <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 17, 2019

Build succeeded

@bors bors bot merged commit 59962de into master Mar 17, 2019
@todo todo bot mentioned this pull request Mar 17, 2019
Closed
@delete-merged-branch delete-merged-branch bot deleted the error-union branch March 17, 2019 03:07
@todo todo bot mentioned this pull request Mar 17, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Mar 21, 2019
Closed
LinusU pushed a commit to LinusU/uuid that referenced this pull request Feb 26, 2020
@ctavan
docs: remove link to last stable version (uuid-rs#373)
54c0b47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodrAus KodrAus KodrAus left review comments

@Dylan-DPC-zz Dylan-DPC-zz Dylan-DPC-zz approved these changes

Assignees

@kinggoesgaming kinggoesgaming

Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kinggoesgaming @Dylan-DPC-zz @KodrAus