add guid feature #338
Merged
add guid feature #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more descriptive than using winapi depname as feature name Signed-off-by: Hunar Roop Kahlon <[email protected]>
Dylan-DPC-zz
approved these changes
Oct 8, 2018
|
Need to add the feature to travis |
|
We can't... GUID is windows specific... It's already tested on appveyor though |
|
Ah yes.. Cool then. |
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Oct 8, 2018
338: add guid feature r=Dylan-DPC a=kinggoesgaming **I'm submitting a(n)** feature # Description Adds `guid` feature which is now used to enable windows GUID support. # Motivation `guid` is a better name for guid support than just `winapi` # Tests No changes # Related Issue(s) #333, #336 Co-authored-by: Hunar Roop Kahlon <[email protected]> Co-authored-by: Dylan DPC <[email protected]>
|
bors r+ |
|
Not awaiting review |
|
😬 |
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a(n) feature
Description
Adds
guidfeature which is now used to enable windows GUID support.Motivation
guidis a better name for guid support than justwinapiTests
No changes
Related Issue(s)
#333, #336