update serde and serde_test crates #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <[email protected]>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Dylan-DPC-zz
requested changes
May 21, 2018
Cargo.toml
Outdated
| @@ -27,7 +27,7 @@ all-features = true | |||
| features = ["serde", "u128", "v1", "v3", "v4", "v5"] | |||
|
|
|||
| [dependencies] | |||
| serde = { version = "1.0.16", optional = true, default-features = false } | |||
| serde = { version = "1", optional = true, default-features = false } | |||
There was a problem hiding this comment.
We can't use the general "1" as a dependency specifier here, since we are depending on a particular "1.0.56" version here for 128 (even though it is optional)
Better to use "1.0.56"
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Dylan-DPC-zz
approved these changes
May 22, 2018
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
May 22, 2018
240: update serde and serde_test crates r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [ ] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description New versions available of both `serde` and `serde_test` # Motivation `u128` support in `1.0.56` `serde` # Tests tests pass # Related Issue(s) #239 Co-authored-by: Hunar Roop Kahlon <[email protected]> Co-authored-by: Dylan DPC <[email protected]>
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
* +package-lock.json because npm requires it * 3.2.0 * README updates * fix: remove mistakenly added typescript dependency, rollback version (standard-version will auto-increment) * chore: fixup README, update package-lock * feat: Add v3 Support (uuid-rs#217) Note: Actual change is in dc02a76. Just making a placeholder commit here so the note gets picked up by standard-version and put in the CHANGELOG.md file. * chore(release): 3.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
New versions available of both
serdeandserde_testMotivation
u128support in1.0.56serdeTests
tests pass
Related Issue(s)
#239