fix: dont throw on log push failure #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
commented
Dec 13, 2024
| @@ -16,5 +16,5 @@ jobs: | |||
|
|
|||
| - name: Run CodeQL | |||
| run: | | |||
| docker run --rm -v $PWD:/app composer sh -c \ | |||
| docker run --rm -v $PWD:/app composer:2.6 sh -c \ | |||
There was a problem hiding this comment.
Required to make codeql job pass, otherwise it runs in php 8.4 and fails with phpstan version
christyjacob4
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes throw from each adapter log push.
Instead, calls
error_logif we encounter a CURL error or a status code >=400It also return the status code, or if it doesn't have one, 500