Split adapters into separate tests for better maintainability #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
force-pushed
the
feat-separate-tests
branch
from
ddf6f6f to
71bf165
Compare
|
@christyjacob4, did our |
|
@stnguyen90 yes I have updated it now |
|
Also the sentry constructor was updated so please sync your PR with |
stnguyen90
force-pushed
the
feat-separate-tests
branch
2 times, most recently
from
9f9a60e to
929fe6b
Compare
stnguyen90
force-pushed
the
feat-separate-tests
branch
from
929fe6b to
f1ec9ca
Compare
|
@christyjacob4, done. |
christyjacob4
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By splitting the adapter tests out, each test won't impact any other tests.