Feat array contains #335
Merged
Feat array contains #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogelito
reviewed
Oct 9, 2023
src/Database/Adapter/MariaDB.php
Outdated
| @@ -218,7 +218,7 @@ public function createAttribute(string $collection, string $id, string $type, in | |||
| $type = $this->getSQLType($type, $size, $signed); | |||
|
|
|||
| if ($array) { | |||
| $type = 'LONGTEXT'; | |||
| $type = 'JSON'; | |||
There was a problem hiding this comment.
We will have to migrate this on Appwrite
There was a problem hiding this comment.
OK
Just saw on MariaDB when trying to create a JSON attribute, It creates this:
genres longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_bin DEFAULT NULL CHECK (json_valid(genres))
While in Mysql it is really a JSON field
There was a problem hiding this comment.
Hmm so we won't need a migration for MariaDB but will for MySQL.. this is a new problem 😅
There was a problem hiding this comment.
Maybe we can save it as Text + create a key / value Collection for search?
fogelito
reviewed
Oct 9, 2023
fogelito
reviewed
Oct 9, 2023
…-contains � Conflicts: � bin/tasks/load.php � src/Database/Adapter/Postgres.php � tests/Database/QueryTest.php
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query::contains