Skip to content

Commit

Permalink
Rename package.json name to fix conflicting with another notion package
Browse files Browse the repository at this point in the history
  • Loading branch information
David Bailey committed Jan 29, 2020
1 parent 65d37ca commit e6d04e0
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ fi

# Install NPM dependencies
if ! [ -f build/app/package-lock.json ]; then
# Replace package name to fix some issues:
# - conflicting package in Ubuntu repos called "notion"
# - icon not showing up properly when only the DEB package is renamed
sed -i 's/"Notion"/"notion-desktop"/' build/app/package.json

# Remove existing node_modules
rm -rf build/app/node_modules

# Configure build settings
Expand All @@ -104,12 +110,13 @@ if ! [ -d build/dist ]; then
--arch x64 \
--out build/dist \
--electron-version $ELECTRON_VERSION \
--executable-name Notion
--executable-name notion-desktop
fi

# Create Debian package
electron-installer-debian \
--src build/dist/app-linux-x64 \
--dest out \
--arch amd64 \
--options.productName Notion \
--options.icon build/dist/app-linux-x64/resources/app/icon.png

0 comments on commit e6d04e0

Please sign in to comment.