This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Improve region endpoint resolver #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull out into separate type and add some more tests about handling of gov, fips and chinese regions. Additionally removes comparison against SDK regions and instead relies on DNS resolution to verify.
|
https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_enable-regions.html#id_credentials_temp_enable-regions_writing_code has more context on setting regions with STS |
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 46.40% 53.72% +7.31%
==========================================
Files 26 30 +4
Lines 1058 1115 +57
==========================================
+ Hits 491 599 +108
+ Misses 516 462 -54
- Partials 51 54 +3
|
* Removed most of the region config setup from sts.DefaultGateway into a configBuilder, added more tests around configBuilder to confirm behaviour * Changed server to request server credentials with the server assume role after configuring for region, should address #368 * Regional endpoint adds a us-iso prefix to handle airgapped regions addressing #410 * Updated version of AWS SDK to 1.35
Make helper funcs hidden
Rename opts to cmd to be consistent
Add some tests for GetPodRole
* Created a Kiam Server integration test to make it easier to test * Extracted server and gateway into builders, tidies complicated construction and makes it easier to test * Move the cacheSize metric from a counter to a gauge and define in metrics.go and outside of DefaultCache func, removes duplicate panic in tests * KiamGatewayBuilder adds WithMaxRetries to configure the gRPC retry behaviour (by default, doesn't retry operations) and potentially helps address #425
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out into separate type and add some more tests about handling of gov, fips and chinese regions.
Additionally removes comparison against SDK regions and instead relies on DNS resolution to verify.
This touches on, but doesn't necessarily fix #410 #368 #344 yet.