This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Remove deprecated RPCs #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for making a major release, and make it easier to implement some other features, this removes from KiamService: - GetRoleCredentials - IsAllowedAssumeRole This change will prevent very old agents interacting with the server.
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 44.06% 45.70% +1.63%
==========================================
Files 26 26
Lines 1096 1070 -26
==========================================
+ Hits 483 489 +6
+ Misses 558 527 -31
+ Partials 55 54 -1
|
tombooth
approved these changes
Oct 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for making a major release, and to make it easier to implement some other features, this removes from KiamService:
This change will prevent very old agents interacting with the server.