This repository was archived by the owner on Mar 5, 2024. It is now read-only.
return empty string if resolver passed empty role #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=========================================
+ Coverage 44.13% 44.2% +0.07%
=========================================
Files 25 25
Lines 929 932 +3
=========================================
+ Hits 410 412 +2
- Misses 475 476 +1
Partials 44 44
|
pingles
reviewed
Aug 16, 2019
pkg/aws/sts/arn_resolver.go
Outdated
| @@ -30,6 +30,11 @@ func DefaultResolver(prefix string) *Resolver { | |||
|
|
|||
| // Resolve converts from a role string into the absolute role arn. | |||
| func (r *Resolver) Resolve(role string) string { | |||
|
|
|||
There was a problem hiding this comment.
@Joseph-Irving remove this whitespace line?
Joseph-Irving
force-pushed
the
fix_arn_resolver
branch
from
edac077 to
cf46349
Compare
pingles
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#276 introduced a bug if you don't set assume-role-arn
arnResolver.Resolve(config.AssumeRoleArn)returns something likearn:aws:iam::xxxxxxxxx:role/when passed an empty assume role arn, which prevents the Default Gateway from using the instance role, it instead trys to assume this non existent role.So I've changed
arnResolver.Resolveto return "" if the role is empty, restoring the old behaviour