This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Update grpc-go from 1.14.0 to 1.23.0 #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DReigada
commented
Aug 14, 2019
| @@ -90,7 +90,6 @@ func NewGateway(ctx context.Context, address string, caFile, certificateFile, ke | |||
| grpc.WithBalancerName(roundrobin.Name), | |||
| grpc.WithDisableServiceConfig(), | |||
| grpc.WithBlock(), | |||
| grpc.WithWaitForHandshake(), | |||
There was a problem hiding this comment.
This is already enabled by default (the method was also removed)
|
Thanks @DReigada. Funnily enough we were talking about this upgrade yesterday! @uswitch/cloud should pick this up. |
|
Thanks for the quick feedback and approval! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc-go version currently used is a bit outdated (1 year old), updating the version will bring some stability improvements as well as bug fixes.