-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow no composition derivatives in get_ATrhoXi_runtime #144
Comments
Could you enable X(0,0,0) too? This would simplify calculating the reduced Helmholtz using dimensionless parameters by not having to back-calculate them from T and rho (via casts to get Tr and rhor). |
Yeah, one sec. I vaguely recall there was a reason why that was a bad idea, but I don't remember what it was. Maybe it was elsewhere now that I think about it. |
I needed a separate approach for 0,0,0, but I sorted it. You should be good to go |
See #144. Still a problem with methanol and fluorine since they use the real critical temperature not the reducing temperature
See
teqp/include/teqp/derivs.hpp
Lines 261 to 279 in ecfcd29
For you @Matthew-Boyd
The text was updated successfully, but these errors were encountered: