Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is PR is in response to a review of the feature/dbio-selected-ep branch which introduces advance query capabilities based around the MongoDB filter query syntax. In particular, it recommends the following changes:
select_constraint_records()
toadv_select_records()
for clarityselect_records()
to allow for arbitrary keyword-value constraints to allow for future simple shortcut queries (e.g.author=Plante
orkeywords=forensics
).check_query_structure()
Unit tests have been updated to adapt to the API changes.
Please test in two ways
scripts/testall.pyunit
(make sure MONGO_TESTDB_URL is not set)test_mongo.py
script:scripts/midasserver -b -M
export MONGO_TESTDB_URL=mongodb://oarop:oarop@localhost:27017/midas
export PYTHONPATH=$PWD/dist/pdr/lib/python
) and dependencies are installed.python python/tests/nistoar/midas/dbio/test_mongo.py
feature/dbio-mongo
branch ofoar-docker
oar-docker/midas
directory../scripts/localdeploy
../scripts/oarctl local build
../scripts/oarctl local up