keyword lowercase and plural + test for multiple keywords research #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayPlante
reviewed
Aug 20, 2024
| @@ -800,7 +800,7 @@ def _summarize(self, nerd: NERDResource): | |||
| out["contactPoint"] = resmd["contactPoint"] | |||
| if 'landingPage' in resmd: | |||
| out["landingPage"] = resmd["landingPage"] | |||
| out["keyword"] = resmd.get("keyword", []) | |||
| out["keywords"] = resmd.get("keywords", []) | |||
There was a problem hiding this comment.
In DAP records, the data property (being set via out in the above code) represents a summary of the NERDm resource metadata (contained in resmd above). We will not be changing the NERDm schema (standardized via a JSON-Schema definition)--only how the selected information is provided in the summary. Thus, the right-side reference to the property should remain singular (which I will fix in a subsequent commit).
There was a problem hiding this comment.
OK good to know, I thought those two had to match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching across both DMPs and DAPs via the portal will be aided where there are common properties under the data field. Currently, general keywords are held under different names between the two project types:
keyWordsvs.keyword, respectively. This PR proposes to change both tokeywords.