Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to rc2->v1.0.0 content converter addresses #958 #960

Merged

Conversation

wendellpiez
Copy link
Contributor

Committer Notes

To resolve #958.

Our eleventh-hour analysis of changes in the metaschemas for v1.0.0 requiring conversion was defective, and missed flag names that had changed in the profile model. This patch addresses that shortcoming.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@david-waltermire david-waltermire changed the base branch from develop to main June 10, 2021 14:16
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes!

@david-waltermire david-waltermire merged commit 5b2d93e into usnistgov:main Jun 10, 2021
@david-waltermire david-waltermire deleted the issue958-rc2v1-upgrade-patch branch June 10, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Upgraders for Conversion from RC2 to 1.0.0 Do Not Upgrade Profile Flag Updates
2 participants