Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra > which shows in the built schemas #1133

Merged

Conversation

guyzyl
Copy link
Contributor

@guyzyl guyzyl commented Feb 9, 2022

Committer Notes

In the assessment-result metaschema there's an extra closing triangle bracket (>) that shows up in the built schemas.
You can see one example of it in the jsonschema.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david-waltermire david-waltermire changed the base branch from develop to main February 10, 2022 18:09
@david-waltermire david-waltermire dismissed their stale review February 10, 2022 18:09

The base branch was changed.

@david-waltermire david-waltermire changed the base branch from main to develop February 10, 2022 18:10
@david-waltermire david-waltermire merged commit 1eb8b06 into usnistgov:develop Feb 10, 2022
@guyzyl guyzyl deleted the remove-stray-triangle-bracket branch February 10, 2022 18:13
stephenbanghart pushed a commit to stephenbanghart/OSCAL that referenced this pull request Mar 14, 2022
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
@david-waltermire david-waltermire added this to the OSCAL 1.1.0 milestone May 4, 2022
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants