Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/20240305 #35

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Features/20240305 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44668c5
fix: workflow name of tf modules validation
using-system Mar 5, 2024
727d747
fix: workflow name of tf modules validation
using-system Mar 5, 2024
5e4a151
fix: set terraform version to 1.6.2
using-system Mar 5, 2024
4db15b8
fix: update aks version to 1.28.5
using-system Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/tf-modules-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: TF Modules - Validaton
name: TF Modules - Validation

on:
push:
Expand All @@ -14,7 +14,7 @@ on:
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
group: ${{ github.workflow }}
cancel-in-progress: false

permissions:
Expand Down Expand Up @@ -46,6 +46,7 @@ jobs:
ARM_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
ARM_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
ARM_USE_OIDC: "true"
TERRAFORM_VERSION: "1.6.2"
strategy:
fail-fast: false
matrix:
Expand All @@ -61,7 +62,7 @@ jobs:
uses: hashicorp/setup-terraform@v3
with:
terraform_wrapper: false
terraform_version: latest
terraform_version: ${{ env.TERRAFORM_VERSION }}

- name: Terraform Version
run: terraform version
Expand Down Expand Up @@ -96,7 +97,7 @@ jobs:
- 'terraform/modules/${{ matrix.modules }}/**'

- name: Terraform Test
if: steps.changes.outputs.module == 'true' || (github.event_name == 'push' && github.ref == 'refs/heads/main') || (github.event_name == 'workflow_dispatch')
if: steps.changes.outputs.module == 'true' || (github.event_name == 'workflow_dispatch')
run: |
OUTPUT=$(terraform test)
echo "$OUTPUT"
Expand Down
4 changes: 2 additions & 2 deletions terraform/modules/az-aks/tests/cluster_creation.tftest.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ run "plan" {
resource_group_name = run.setup.resource_group_name
name = "az-aks-cluster"
configuration = {
version = "1.27.3"
version = "1.28.5"
sku = "Free"
private_cluster = true
user_assigned_identity_id = run.setup.assigned_identity_id
Expand Down Expand Up @@ -99,7 +99,7 @@ run "apply" {
resource_group_name = run.setup.resource_group_name
name = "az-aks-cluster"
configuration = {
version = "1.27.3"
version = "1.28.5"
sku = "Free"
private_cluster = true
user_assigned_identity_id = run.setup.assigned_identity_id
Expand Down
Loading