Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support given firstweekday #37

Merged
merged 17 commits into from
Jun 30, 2024
Merged

feat: support given firstweekday #37

merged 17 commits into from
Jun 30, 2024

Conversation

usharerose
Copy link
Owner

Support parameter firstweekday which define the first day of a week

0 is Monday, and 6 is Sunday.

It can represent several week number system:

  • firstweekday=0: ISO week (from Monday through Sunday)
  • firstweekday=6: US system (from Sunday through Saturday)

However, the definition of one year / month's first week would still follow this rule referred to ISO 8601:

the fourth day of a week determine this week's affiliation since it presents the majority (4 or more) of a week

@usharerose usharerose self-assigned this Jun 29, 2024
Copy link

github-actions bot commented Jun 29, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py30100% 
api.py70100% 
app.py57885%46, 52, 68–69, 95–96, 121–122
date_utils
   __init__.py29872%23, 36–39, 44–46
   common.py185995%470, 481, 520, 532, 564, 589, 599, 610, 620
   date_granularity.py118794%25, 41, 51, 65, 74, 89, 98
   date_range.py400100% 
   offset_granularity.py250100% 
TOTAL4643293% 

Tests Skipped Failures Errors Time
144 0 💤 0 ❌ 0 🔥 0.474s ⏱️

@usharerose usharerose merged commit ac421f2 into main Jun 30, 2024
18 checks passed
@usharerose usharerose deleted the feat-firstweekday branch June 30, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant