Add reports search form #220 #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick screen shot of the searching ui |
|
@kamaulynder @aoduor This has missed 2.6 now but could one you code review anyway? |
|
will review, queued in my plate. On Tue, Oct 9, 2012 at 12:19 AM, Robbie MacKay [email protected]:
Too brief? Here's why! http://emailcharter.org |
Adding reports search form to admin/reports pages. Searching by: * Category * Approved * Verified * Keyword * Location * Media type * Mode (SMS/Web/Twitter) * Date
…ahidi#220 This makes sure we still get results if from and to dates are the same. Also more closely matches what a user would expect
|
Rebased from 2.6 and fixed a bug in fetch_incidents that gave weird search results by date |
aoduor
added a commit
that referenced
this pull request
Nov 23, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love a quick code review and testing on this.. its a little messy since I'm working around the existing UI, so want to be sure I haven't missed anything.
Adding reports search form to admin/reports pages. Searching by: