Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored tutor prompt by emulating the old prompt interface #2144

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DavyLandman
Copy link
Member

@DavyLandman DavyLandman commented Feb 11, 2025

In the future we could consider generating input streams where we pipe commands to, but that would still be messy, since we have to intercept the eval results. and the current tutor interface expects us to not print the repl prompt on application/rascal+stdout map, so we would also have to change that.

so instead, this PR is the smallest thing I could do to get it to work as it used to.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 50%. Comparing base (c62894d) to head (fcff180).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...r/lang/rascal/tutor/repl/TutorCommandExecutor.java 0% 27 Missing ⚠️
...rascal/tutor/repl/TutorCommandExecutorCreator.java 0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2144   +/-   ##
=======================================
- Coverage       50%     50%   -1%     
- Complexity    6241    6249    +8     
=======================================
  Files          677     677           
  Lines        59017   59043   +26     
  Branches      8619    8623    +4     
=======================================
+ Hits         29542   29548    +6     
- Misses       27241   27257   +16     
- Partials      2234    2238    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jurgenvinju
Copy link
Member

jurgenvinju commented Feb 11, 2025

Only missing commenting back in the use of "repl.prompt()" seems to be missing. In rascal code. I'll look it up later if it's hard to find.

@DavyLandman DavyLandman changed the title Restored deleted tutor prompt function from history Restored tutor prompt by emulating the old prompt interface Feb 11, 2025
@DavyLandman
Copy link
Member Author

@jurgenvinju I think now everything it working again in this simulation, shall we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants