-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utils): improve normalizeFileName to support Unicode characters #569
base: main
Are you sure you want to change the base?
feat(utils): improve normalizeFileName to support Unicode characters #569
Conversation
- Update the `normalizeFileName` function to use a RegExp that supports Unicode characters - Add tests for `normalizeFileName` with various Unicode languages
Hi @helloanoop 👋, Firstly, I would like to express my sincere gratitude 🙏 for developing such an outstanding project. If possible, we would appreciate it if you could give this Pull Request a higher priority. Currently, importing data in Postman format is an obstacle for those trying to use Bruno😵💫 As a native Japanese speaker, |
There are more codes that should be changed:
I checked regexes having Another related issue: #1274 |
Is there any plan to merge this branch? |
still waiting... |
still waiting |
use hoppscotch instead. |
This PR improves the
normalizeFileName
function in theutils
package to support Unicode characters. Previously, the function could not correctly handle file names with Unicode characters. This update allows it to correctly replace non-alphanumeric, non-space, non-hyphen, and non-underscore characters in any language with a hyphen.Changes include:
normalizeFileName
function to use a RegExp that supports Unicode characters.normalizeFileName
with various Unicode languages.This enhancement will allow our application to handle file names in any language, improving its usability for non-English users.