Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search dialog overlapping code editor #3965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pooja-bruno
Copy link
Collaborator

@pooja-bruno pooja-bruno commented Feb 7, 2025

Description

This PR fixes an issue where the search dialog was overlapping the first few lines of the code editor, affecting readability. The dialog is now positioned correctly without obstructing the code content.

Changes Introduced:

  • Added .dialog-opened class to provide padding when the dialog is active.
  • Repositioned the search dialog to be fixed at the top with proper spacing.
  • Enhanced search dialog styling with improved borders, shadows, and background colors.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.
image

@helloanoop
Copy link
Contributor

@pooja-bruno I discussed this with @lohit-bruno and merged an alternative approach in PR #3983.
Could you test it and confirm if we missed any edge cases?

If everything looks good, we can go ahead and close this PR.

@pooja-bruno
Copy link
Collaborator Author

@helloanoop, I’ve checked it, and it looks good to me. Didn’t find any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants