-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: request/folder names should be independent of the actual file/directory name #3094
Open
lohxt1
wants to merge
47
commits into
usebruno:main
Choose a base branch
from
lohxt1:feat/file-name--request-name--2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,242
−525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohxt1
changed the title
Feat/file name request name 2
feat: request/folder names should be independent of the actual file/directory name
Sep 13, 2024
This was referenced Sep 15, 2024
This was referenced Oct 18, 2024
Any ETA on this long outstanding wish? |
~ file explorer mode to modify the bru file content directly in app ~ added linter for bru file types in codemirror ~ command+shift+m hotkey for switching view modes (request/file)
~ watcher add/change logic for all file types ~ component for dynamically setting file icon based on file extension ~ ability to modify file contents in file explorer mode
~ requests should always show in same order in both request/file mode ~ folders should always appear before requests/misc files ~ folders should appear alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
~ request/folder name should not be normalized
~ should be independent of the actual file/directory name
request-folder-names.mp4
file explorer view:
file_explorer_.mp4
bruno app:
filesystem:
uses the below sanitize and validate functions for creating files/directories, extending the regex from @Its-treason's pr #349.
bruno/packages/bruno-app/src/utils/common/regex.js
Line 3 in 5d197b1
bruno/packages/bruno-app/src/utils/common/regex.js
Line 11 in 5d197b1
Contribution Checklist: