Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate VM2 #263

Open
3 tasks
helloanoop opened this issue Sep 30, 2023 · 5 comments · Fixed by #1400 · May be fixed by #1565
Open
3 tasks

Deprecate VM2 #263

helloanoop opened this issue Sep 30, 2023 · 5 comments · Fixed by #1400 · May be fixed by #1565

Comments

@helloanoop
Copy link
Contributor

We've had great success with vm2 in running scripts inside a sandbox.
The project vm2 however has been currently discontinued and not recommended for production usage.

The recommended alternative is isolated-vm

We want to eventually move to an alternative that is being maintained. I don't want to rush at the moment. There are plenty more things that stack higher in priority.

Here is how an our tasklist to get this done should look like

  • a solid test suite that covers a lot of scripting capabilities
  • deprecate vm2, move to a isolated-vm, but allow users to fallback to vm2 via toggle if their tests start start failing
  • once the new vm is stable, drop vm2
@Its-treason
Copy link
Member

I investigated isolated-vm and I don't think this is a viable replacement in our use case, because it does not support external or internal node modules like fs laverdet/isolated-vm#27.

@helloanoop
Copy link
Contributor Author

Thanks @Its-treason !

I am thinking that we can fork vm2 to bruno's org and release a version under the package @usebruno/vm2
This seems to me a good short term solution until we find a better one.

@Its-treason
Copy link
Member

This or using an existing fork like https://github.com/n8n-io/vm2 / https://www.npmjs.com/package/@n8n/vm2

This fork fixed both vulnerabilities with a workaround.

@helloanoop
Copy link
Contributor Author

@Its-treason I have rolled back this PR since it was breaking scripting - #1487

@helloanoop helloanoop reopened this Jan 30, 2024
Its-treason added a commit to Its-treason/bruno that referenced this issue Feb 10, 2024
Its-treason added a commit to Its-treason/bruno that referenced this issue Feb 18, 2024
Its-treason added a commit to Its-treason/bruno that referenced this issue Mar 5, 2024
@tonytvo
Copy link

tonytvo commented Aug 22, 2024

@helloanoop is there anything I can do to get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants