-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate VM2 #263
Comments
I investigated |
Thanks @Its-treason ! I am thinking that we can fork |
This or using an existing fork like https://github.com/n8n-io/vm2 / https://www.npmjs.com/package/@n8n/vm2 This fork fixed both vulnerabilities with a workaround. |
@Its-treason I have rolled back this PR since it was breaking scripting - #1487 |
@helloanoop is there anything I can do to get this merged in? |
We've had great success with vm2 in running scripts inside a sandbox.
The project vm2 however has been currently discontinued and not recommended for production usage.
The recommended alternative is isolated-vm
We want to eventually move to an alternative that is being maintained. I don't want to rush at the moment. There are plenty more things that stack higher in priority.
Here is how an our tasklist to get this done should look like
vm2
, move to aisolated-vm
, but allow users to fallback tovm2
via toggle if their tests start start failingvm2
The text was updated successfully, but these errors were encountered: