-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize get property for most primitive types #974
Conversation
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
===========================================
- Coverage 78.97% 63.81% -15.16%
===========================================
Files 244 244
Lines 9122 9148 +26
===========================================
- Hits 7204 5838 -1366
- Misses 1918 3310 +1392
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes total sense to me. No need to bubble this up to the poor user. Those should be infallible.
Implements #972.
The main trick in this PR is that we "trust" SEAL in that it delivers correct inputs to ink! result buffers for functions like
seal_caller
.Before this PR we additionally "checked" the given values by decoding them. Now we simply take their bit patterns directly.
This has turned many of the property functions into infallible functions.
Benchmarks
Savings are not huge but go into the right direction.