Base Key on [u8; 32] #971
Merged
Base Key on [u8; 32] #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow those new implementations optimize better ...
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 78.86% 78.75% -0.12%
==========================================
Files 243 244 +1
Lines 9124 9122 -2
==========================================
- Hits 7196 7184 -12
- Misses 1928 1938 +10
Continue to review full report at Codecov.
|
Generic over T where T: Into<u64> so it accepts u32 as well etc.
…y-on-u8x32 # Conflicts: # .config/cargo_spellcheck.dic
cmichi
approved these changes
Oct 21, 2021
This was referenced Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #950.
This change removes lots of APIs from
Keytype that may result in inefficient computation.This required some changes in the rest of the ink! codebase.
Unfortunately this PR slightly pessimizes Wasm file sizes.
For example the ERC-20 contract Wasm file size is 29.4kB without this change and 29.5kB with this change.
Even through the pessimization with respect to Wasm file sizes I believe that this change will allow other optimizations.
This PR is best reviewed commit by commit.