Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦖 pin curve25519-dalek to 4.1.1 to fix linting CI #2103

Merged
merged 2 commits into from
Feb 8, 2024
Merged

🦖 pin curve25519-dalek to 4.1.1 to fix linting CI #2103

merged 2 commits into from
Feb 8, 2024

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Feb 7, 2024 •
edited
Loading

@ascjones ascjones changed the title 🦖 pin curve25519-dalek to 4.1.1 to fix linting 🦖 pin curve25519-dalek to 4.1.1 to fix linting CI Feb 7, 2024
smiasojed
smiasojed approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@smiasojed smiasojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jubnzv
jubnzv approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For now it's the best workaround. We cannot simply update clippy_utils, since it depends on the previous nightly toolchain.

@ascjones ascjones merged commit b6880dd into master Feb 8, 2024
22 of 23 checks passed
@ascjones ascjones deleted the aj/pin-curve25519-dalek branch February 8, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubnzv jubnzv jubnzv approved these changes

@smiasojed smiasojed smiasojed approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascjones @jubnzv @smiasojed