Experiment to improve E2E call builder API #1669
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing around to see how we can simply remove the existing ugly callback API for building message calls. The requirements are:
ink
call builder codegen.With this idea I have converted
erc20
to the new syntax which removes the unergonomic callback. Thus we can now usecall
on the type returned frominstantiate
:To test this run e2e tests on the
erc20
example.Things to see whether we improve
instantiate
, see.instantiate::<Erc20, _, _>
abovelet mut
contract ref to access messages with&mut self
receivers.Clone
impls added to the call builders (required because many call builder methods consumeself
)