Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Conditional Codegen for Messages, Constructors and Events" PR #1479

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

SkymanOne
Copy link
Contributor

This reverts #1458 as functionality is not working. Need to rethink the approach

This reverts commit 06e9cf2.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Merging #1479 (f4b07f5) into master (6b24de9) will increase coverage by 22.88%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           master    #1479       +/-   ##
===========================================
+ Coverage   46.97%   69.85%   +22.88%     
===========================================
  Files         201      201               
  Lines        6210     6194       -16     
===========================================
+ Hits         2917     4327     +1410     
+ Misses       3293     1867     -1426     
Impacted Files Coverage Δ
crates/ink/codegen/src/generator/dispatch.rs 94.54% <ø> (+94.54%) ⬆️
crates/ink/ir/src/ir/item_impl/mod.rs 90.67% <ø> (+26.33%) ⬆️
crates/ink/ir/src/ir/item_mod.rs 89.65% <66.66%> (+27.94%) ⬆️
crates/ink/codegen/src/generator/events.rs 97.26% <100.00%> (+97.26%) ⬆️
crates/ink/ir/src/ir/item_impl/iter.rs 100.00% <100.00%> (ø)
crates/engine/src/chain_extension.rs 19.04% <0.00%> (-23.81%) ⬇️
crates/env/src/engine/off_chain/types.rs 0.00% <0.00%> (-21.06%) ⬇️
crates/engine/src/test_api.rs 72.52% <0.00%> (-13.19%) ⬇️
crates/engine/src/ext.rs 55.05% <0.00%> (-12.93%) ⬇️
crates/env/src/engine/off_chain/impls.rs 36.47% <0.00%> (-11.18%) ⬇️
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ascjones ascjones merged commit f03f2a6 into master Nov 8, 2022
@ascjones ascjones deleted the gn/revert-pr branch November 8, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants