Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract traits into crate ink_traits #1449

Closed
wants to merge 1 commit into from
Closed

Extract traits into crate ink_traits #1449

wants to merge 1 commit into from

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Oct 25, 2022

Preparation for more work on #1234.

@cmichi cmichi force-pushed the cmichi-move-traits-into-dedicated-crate branch 3 times, most recently from b841041 to 7b9f85d Compare October 25, 2022 06:33
ascjones
ascjones reviewed Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a bit more detail in the description for the motivation for this. e.g. preventing a circular dependency.

@cmichi cmichi force-pushed the cmichi-move-traits-into-dedicated-crate branch from 7b9f85d to e49cccb Compare October 25, 2022 09:41
@HCastano
Copy link
Contributor

HCastano commented Dec 19, 2022 •
edited
Loading

@cmichi is this still something that we want/need to do?

@HCastano
Copy link
Contributor

Feel free to re-open if this comes up again

@HCastano HCastano closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones left review comments

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmichi @HCastano @ascjones