Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature no-allocator to ink_allocator #1415

Closed
wants to merge 1 commit into from

Conversation

kvinwang
Copy link
Contributor

Fixes #1414

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #1415 (55fc77a) into master (69f959f) will increase coverage by 6.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
+ Coverage   65.92%   71.99%   +6.07%     
==========================================
  Files         187      187              
  Lines        5951     5953       +2     
==========================================
+ Hits         3923     4286     +363     
+ Misses       2028     1667     -361     
Impacted Files Coverage Δ
crates/allocator/src/bump.rs 85.95% <0.00%> (-1.45%) ⬇️
crates/ink/ir/src/ir/attrs.rs 82.27% <0.00%> (+3.60%) ⬆️
crates/ink/ir/src/ir/item_impl/callable.rs 91.91% <0.00%> (+4.04%) ⬆️
crates/ink/ir/src/ir/trait_def/item/mod.rs 90.16% <0.00%> (+4.91%) ⬆️
crates/ink/ir/src/ir/item_impl/constructor.rs 93.84% <0.00%> (+6.15%) ⬆️
crates/ink/ir/src/ir/selector.rs 88.00% <0.00%> (+8.00%) ⬆️
crates/ink/ir/src/ir/idents_lint.rs 71.42% <0.00%> (+9.52%) ⬆️
crates/ink/ir/src/ir/item_impl/message.rs 92.13% <0.00%> (+14.60%) ⬆️
crates/ink/ir/src/ir/item/mod.rs 60.71% <0.00%> (+16.66%) ⬆️
crates/ink/ir/src/ir/item_impl/impl_item.rs 57.44% <0.00%> (+17.02%) ⬆️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tolak
Copy link

tolak commented Oct 18, 2022

I was trying to use some types from substrate FRAME, which will lead to a global_allocator conflict with the one used ink, that makes me think about should we need an approach to enable/disable the global_allocator like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider add dlmalloc-rs as allocator or opt-out the BumpAllocator
4 participants