Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove codecov stage #1405

Merged
merged 1 commit into from
Sep 20, 2022
Merged

CI: Remove codecov stage #1405

merged 1 commit into from
Sep 20, 2022

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Sep 20, 2022

We've migrated ink! to Rust stable, the current codecov setup runs only in nightly (due to -Z RUSTFLAGS). Our test fixtures have different output for stable though, hence codecov fails.

It's unfortunate. I've created this follow-up ticket to bring it back: https://github.com/paritytech/ci_cd/issues/611.

We've migrated ink! to `stable` Rust, the current `codecov`
setup runs only in `nightly`. Our test fixtures have different
output for `stable` though, hence `codecov` fails.
@cmichi cmichi requested review from a team, ascjones and HCastano as code owners September 20, 2022 07:43
@cmichi cmichi merged commit 01115f3 into master Sep 20, 2022
@cmichi cmichi deleted the cmichi-remove-codecov branch September 20, 2022 08:59
cmichi added a commit that referenced this pull request Sep 20, 2022
ascjones pushed a commit that referenced this pull request Sep 20, 2022
We've migrated ink! to `stable` Rust, the current `codecov`
setup runs only in `nightly`. Our test fixtures have different
output for `stable` though, hence `codecov` fails.
HCastano added a commit that referenced this pull request Sep 23, 2022
* Revert "Remove `codecov` CI stage (#1405)"

This reverts commit 01115f3.

* Set `RUSTC_BOOTSTRAP`

* Update .gitlab-ci.yml

Co-authored-by: Andrew Jones <[email protected]>

Co-authored-by: Andrew Jones <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant