Move linting checks to start of CI run #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
requested review from
ascjones,
cmichi,
Robbepop and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
+ Coverage 78.75% 78.79% +0.04%
==========================================
Files 248 248
Lines 9371 9371
==========================================
+ Hits 7380 7384 +4
+ Misses 1991 1987 -4
Continue to review full report at Codecov.
|
cmichi
reviewed
Dec 1, 2021
| #### stage: lint | ||
| # | ||
| # Note: For all of these lints we `allow_failure` so that the rest of the build can | ||
| # continue running despite them not passing. Merging is still disallowed since (most) of |
There was a problem hiding this comment.
Just as an FYI: I checked and it's only spellcheck which is currently not required for merging.
xgreenx
pushed a commit
to Supercolony-net/ink
that referenced
this pull request
Feb 8, 2022
* Move linting checks to start of CI run * Test RustFmt failure * Test Clippy quickfail * Try adding `allow_failure` to Clippy jobs * Allow lint steps to fail in the GitLab CI * Revert test failures in `flipper`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really annoying to wait half an hour while the CI does its job, only to realize that
you forgot to run
rustfmtand now you have to wait another half an hour for the CI topass.
This PR moves our linting steps to the beginning of the CI pipeline so that these
failures can be caught and addressed quickly.
This PR also allows the CI build to continue despite the lint steps failing. This is
useful if you care about a step later in the CI pipeline (e.g contract sizes) but don't
necessarily care if your code is formatted properly.