Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug CI: Remove workspace from delegator #1055

Closed
wants to merge 3 commits into from

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 29, 2021

Not intended for merge, this is just here to debug the failing CI for #1054.

@paritytech-ci
Copy link

paritytech-ci commented Nov 29, 2021

🦑 📈 ink! Example Contracts ‒ Size Change Report 📉 🦑

These are the results of building the examples/* contracts from this branch with cargo-contract 0.16.0:

Δ Original Size Δ Optimized Size Total Optimized Size
accumulator -6.23 K -4.39 K 0.00 K
adder -28.39 K -7.36 K 0.00 K
contract-terminate 20.52 K
contract-transfer 20.03 K
delegator 28.02 K
dns 32.57 K
erc1155 51.79 K
erc20 88.03 K
erc721 34.31 K
flipper 84.63 K
incrementer 20.95 K
multisig 20.72 K
proxy 105.32 K
rand-extension 23.86 K
subber -28.39 K -7.37 K 26.52 K
trait-erc20 64.41 K
trait-flipper 20.67 K
trait-incrementer 20.69 K

Link to the run | Last update: Mon Nov 29 12:36:37 CET 2021

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #1055 (1d44097) into master (141673b) will decrease coverage by 3.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
- Coverage   78.78%   75.65%   -3.14%     
==========================================
  Files         248      248              
  Lines        9363     9361       -2     
==========================================
- Hits         7377     7082     -295     
- Misses       1986     2279     +293     
Impacted Files Coverage Δ
crates/lang/ir/src/ir/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/ir/src/ir/ink_test.rs 0.00% <0.00%> (-87.50%) ⬇️
crates/lang/ir/src/ir/trait_def/mod.rs 0.00% <0.00%> (-66.67%) ⬇️
crates/lang/ir/src/ir/blake2.rs 16.66% <0.00%> (-62.50%) ⬇️
crates/lang/ir/src/ir/trait_def/item/trait_item.rs 45.31% <0.00%> (-43.75%) ⬇️
crates/lang/ir/src/ir/trait_def/config.rs 7.69% <0.00%> (-38.47%) ⬇️
crates/lang/ir/src/ir/utils.rs 53.84% <0.00%> (-30.77%) ⬇️
crates/lang/ir/src/ir/item_mod.rs 62.28% <0.00%> (-27.43%) ⬇️
crates/lang/ir/src/ir/item_impl/mod.rs 66.94% <0.00%> (-23.73%) ⬇️
crates/lang/ir/src/ir/config.rs 68.08% <0.00%> (-23.41%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141673b...1d44097. Read the comment docs.

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 29, 2021

🦑 📈 ink! Example Contracts ‒ Size Change Report 📉 🦑

These are the results of building the examples/* contracts from this branch with cargo-contract 0.16.0:

Link to the run | Last update: Mon Nov 29 09:44:54 CET 2021

It failed to parse the result=)
image

@cmichi cmichi closed this Nov 30, 2021
@cmichi cmichi deleted the cmichi-debug-xgreenx-workspace-pr branch November 30, 2021 07:44
@xgreenx
Copy link
Collaborator

xgreenx commented Nov 30, 2021

@cmichi Something is wrong with Total Optimized Size in the size report=). It is huge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants