Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ink! 3.0.0-rc7 #1043

Merged
merged 6 commits into from
Nov 25, 2021
Merged

Release ink! 3.0.0-rc7 #1043

merged 6 commits into from
Nov 25, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 25, 2021

Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #1043 (c8abe37) into master (71a2c38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1043   +/-   ##
=======================================
  Coverage   78.78%   78.78%           
=======================================
  Files         248      248           
  Lines        9363     9363           
=======================================
  Hits         7377     7377           
  Misses       1986     1986           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a2c38...c8abe37. Read the comment docs.

@paritytech-ci
Copy link

paritytech-ci commented Nov 25, 2021

🦑 📈 ink! Example Contracts ‒ Size Change Report 📉 🦑

These are the results of building the examples/* contracts from this branch with cargo-contract 0.15.0:

No size changes were observed.

Link to the run | Last update: Thu Nov 25 10:37:36 CET 2021

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 25, 2021

I think that bug is critical for that release because a workaround doesn't exist.

Maybe you have time to fix that or check #983 with my suggestion about the fix?

@Robbepop
Copy link
Collaborator

Robbepop commented Nov 25, 2021

I think that bug is critical for that release because a workaround doesn't exist.

Maybe you have time to fix that or check #983 with my suggestion about the fix?

We can fix this bug for another RC. no need to delay this already big release imo. We should better do another smaller release soon.

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 25, 2021

We can fix this bug for another RC. no need to delay ghis release imo.

For OpenBrush it means that we will use rc6=( If you agree with the suggested fix I will implement it today and you can release it=)

@Robbepop
Copy link
Collaborator

I will need more time for that. We will be trying to release another smaller release very soon. A smaller follow-up release makes sense anyways since this one is already quite huge.

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 25, 2021

Okey=( Hope the next RC will be soon=) Because that bug is a blocker for us

@Robbepop
Copy link
Collaborator

Okey=( Hope the next RC will be soon=) Because that bug is a blocker for us

The issues will be put on top of my priority list. ;)

@cmichi cmichi merged commit 6cde90c into master Nov 25, 2021
@cmichi cmichi deleted the cmichi-release-ink-rc7 branch November 25, 2021 10:59
xgreenx pushed a commit to Supercolony-net/ink that referenced this pull request Feb 8, 2022
* Bump `3.0.0-rc6` ➔ `3.0.0-rc7`

* Update release notes

* Update release notes

* Remove outdated changelog note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants