Arpa 28 humble #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thanks for the contribution, this is awesome. --> # PR Details ## Description Ported both cpp_message and j2735 convertor packages to new repo and is able to build successfully. Unit tests for both packages pass as well. This code should be merged into a branch "develop-foxy" since this build uses the foxy version ## Related GitHub Issue <!--- This project only accepts pull requests related to open GitHub issues or Jira Keys --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please DO NOT name partially fixed issues, instead open an issue specific to this fix --> <!--- Please link to the issue here: --> ## Related Jira Key ARPA-4 ## Motivation and Context Both packages were ported to a new repository outside of CARMA messenger to allow for both packages to be used by other projects aside from CARMA messenger. ## How Has This Been Tested? Unit tests were ran to ensure new package works as expected ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Defect fix (non-breaking change that fixes an issue) - [x ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have added any new packages to the sonar-scanner.properties file - [ ] My change requires a change to the documentation. - [x ] I have updated the documentation accordingly. - [ ] I have read the [**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md) document. - [ ] I have added tests to cover my changes. - [x ] All new and existing tests passed.
|
Looks like this branch has diverged from develop. Let's rebase or merge develop into the branch and resolve the merge conflicts so we're only tracking the intended updates. |
adev4a
reviewed
Jan 31, 2025
|
Looks like CI is failing because carma-j2735 wasn't found. That would need to be added as a step in the github workflow |
adev4a
reviewed
Feb 2, 2025
| # Testing | ||
| if(BUILD_TESTING) | ||
| target_link_libraries(${node_exec} ${node_lib}) | ||
| target_include_directories(${node_exec} |
There was a problem hiding this comment.
Seems like we have target_link_libraries and target_include_directories specified twice and this second instance removes reference to stol-j2735
| @@ -58,37 +63,43 @@ ament_auto_add_library(${node_lib} SHARED | |||
| ) | |||
|
|
|||
|
|
|||
| add_library(testlib SHARED IMPORTED) | |||
| ament_target_dependencies(${node_lib} | |||
There was a problem hiding this comment.
This can be removed, class_loader is not used and rclcpp and rclcpp_components dependencies should be found by ament_auto_find_build_dependencies
adev4a
reviewed
Feb 3, 2025
| # Testing | ||
| if(BUILD_TESTING) | ||
| # target_link_libraries(${node_exec} ${node_lib}) | ||
| # target_include_directories(${node_exec} |
There was a problem hiding this comment.
Can we remove these commented lines?
| carma_package() | ||
|
|
||
| find_package(ros_environment REQUIRED) |
There was a problem hiding this comment.
We can remove lines 22 and 24 here we dont need to check ros-version since this is meant for ros2-humble only
adev4a
approved these changes
Feb 3, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Changed repo to have v2x-ros conversion to use the STOL APT repo for carma-j2735 encoding/decoding rather than using the files with the manual changes to them. This is for the humble version of the repo
Related GitHub Issue
Related Jira Key
ARPA-28
Motivation and Context
How Has This Been Tested?
Checked to see if dev container is able to launch. Once inside the dev container, the unit tests were tested to see if they pass as well as using roslaunch to launch the cpp_message node.
Types of changes
Checklist: