Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arpa 18 fix v2x ros conversion #11

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

radishco
Copy link
Contributor

@radishco radishco commented Feb 3, 2025

PR Details

Description

Related GitHub Issue

Related Jira Key

Motivation and Context

Needed to add the cpp_message and j2735_convertor to the cmakelist and package.xml for the v2x-ros-conversion node so that the v2x-ros-conversion node can launch both of the other nodes.

How Has This Been Tested?

Tested by confirming build works inside dev container and unit tests pass and ros is able to launch

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@radishco radishco requested a review from adev4a February 3, 2025 21:28
@adev4a adev4a changed the base branch from develop to develop-foxy February 3, 2025 21:49
@radishco radishco merged commit 15eef16 into develop-foxy Feb 3, 2025
3 checks passed
@adev4a adev4a deleted the arpa-18-fix-v2x-ros-conversion branch February 3, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants