Update Sonar Scanner version for Improved Compatibility #185
Conversation
Dockerfile
Outdated
| @@ -255,8 +260,13 @@ RUN sed -i 's|http://archive.ubuntu.com|http://us.archive.ubuntu.com|g' /etc/apt | |||
| sudo -u carma rosdep --rosdistro noetic install --from-paths /home/carma/.base-image/workspace/src --ignore-src -y && \ | |||
| sudo -u carma echo "source ~/.base-image/init-env.sh" >> /home/carma/.bashrc && \ | |||
| sudo -u carma echo "cd /opt/carma" >> /home/carma/.bashrc && \ | |||
| apt-get update && \ | |||
| apt-get install -y --no-install-recommends ${BASE_DEPS} && \ | |||
There was a problem hiding this comment.
Are these two lines needed, since they have already been executed earlier in the Dockerfile?
| python3-catkin-pkg \ | ||
| python3-catkin-tools \ | ||
| python3-colcon-common-extensions \ | ||
| python3-future \ | ||
| python3-lttng \ |
There was a problem hiding this comment.
For some reason this PR looks like it is adding new packages to be installed in the Dockerfile under ROS_DEPS, but they are already included on the develop branch. Would you mind looking into resolving this, or alternatively starting clean and putting up a new PR?
| @@ -108,13 +108,18 @@ ARG ROS_DEPS="apt-transport-https \ | |||
| libopenblas-dev \ | |||
| libpcap-dev \ | |||
| libpugixml-dev \ | |||
| lttng-tools \ | |||
There was a problem hiding this comment.
Not a specific comment on this code change, but please create a GitHub Issue in the carma-platform repository that we can link this PR to. It would be great if you can include the deprecated warning that we are receiving in that issue as well.
|
Closing this PR and opened new one due to branch issue (Addressed all above comments in new PR) : #186 |
PR Details
Updated Sonar Scanner to version 5.0.1.3006, compatible with Java 17.
Description
This update addresses the need for keeping our environment aligned with the latest supported Java version for Sonar Scanner. The deprecated support for Java 11 necessitated this upgrade. These changes ensure our build and analysis processes remain efficient and up-to-date with current standards.
Related GitHub Issue
Related Jira Key
Motivation and Context
How Has This Been Tested?
Docker build process tested locally to ensure the successful installation of Java 17 and the new Sonar Scanner version to remove the deprecated warningTypes of changes
Checklist: