Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin plotly to the latest stable release instead of release candidate #1992

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Rwolfe-Nava
Copy link
Collaborator

@Rwolfe-Nava Rwolfe-Nava commented Jan 10, 2025

Link to ZenHub issue.

What does this change?

Plotly is set to pull down the latest version. The latest version we pulled in is 6.0.0rc0, which deprecated scatter_map and likely introduces breaking changes for sites that use strict CSP (like we do).

See:
https://github.com/plotly/plotly.py/releases
plotly/dash#1794 (comment)

This PR is to pin plotly to the last stable release version (5.24.1) to hopefully resolve the issue.

Screenshots (for front-end PR):

Checklist:

Author

  • If this is a story, run locally and check to make sure all Acceptance Criteria are met. (If any criteria are unclear, ask about them.).
  • Check for, document, and establish a testing plan for any behavior that may vary across environments or is otherwise difficult to test.
  • Check for accessibility.
  • Tests pass.

Reviewer

  • If this is a story, run locally and check to make sure all Acceptance Criteria are met. (If any criteria are unclear, ask about them.).
  • Check for any behavior that may vary across environments or is difficult to test, and ensure that it is well-understood, documented, and that there is a testing plan in place.
  • Re-check for accessibility.
  • Tests pass.

Notes for reviewer:

See PR instructions doc for full pull request review instructions.

@Rwolfe-Nava Rwolfe-Nava marked this pull request as ready for review January 10, 2025 21:50
@Rwolfe-Nava Rwolfe-Nava requested a review from okkays January 10, 2025 21:50
Copy link
Collaborator

@okkays okkays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🤞!

I agree we should not be tracking a release candidate for this library.

@Rwolfe-Nava Rwolfe-Nava merged commit 699874c into develop Jan 10, 2025
1 check passed
@Rwolfe-Nava Rwolfe-Nava deleted the rw/revert-plotly-to-stable-release branch January 10, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants