Accept Symbol

README.md

@@ -45,10 +45,10 @@ res = fetch('https://example.com')
 
 Options for `fetch` method:
 
-- `method`: HTTP method (default: `'GET'`)
+- `method`: HTTP method (default: `:get`)
 - `headers`: Request headers (default: `{}`)
 - `body`: Request body (default: `nil`)
-- `redirect`: Follow redirects (one of `'follow'`, `'error'`, `'manual'`, default: `'follow'`)
+- `redirect`: Follow redirects (one of `:follow`, `:error`, `:manual`, default: `:follow`)
 
 Methods of `Fetch::Response` object:
 
@@ -65,7 +65,7 @@ Methods of `Fetch::Response` object:
 
 ``` ruby
 res = fetch('http://example.com', **{
-  method: 'POST',
+  method: :post,
 
   headers: {
     'Content-Type' => 'application/json'
@@ -81,7 +81,7 @@ res = fetch('http://example.com', **{
 
 ``` ruby
 res = fetch('http://example.com', **{
-  method: 'POST',
+  method: :post,
 
   body: Fetch::URLSearchParams.new(
     name: 'Alice'
@@ -93,7 +93,7 @@ res = fetch('http://example.com', **{
 
 ``` ruby
 res = fetch('http://example.com', **{
-  method: 'POST',
+  method: :post,
 
   body: Fetch::FormData.build(
     name: 'Alice',

lib/fetch/client.rb

@@ -13,7 +13,7 @@ module Fetch
   class Client
     include Singleton
 
-    def fetch(resource, method: 'GET', headers: [], body: nil, redirect: 'follow', _redirected: false)
+    def fetch(resource, method: :get, headers: [], body: nil, redirect: 'follow', _redirected: false)
       uri = URI.parse(resource)
       req = Net::HTTP.const_get(method.capitalize).new(uri)
 
@@ -48,15 +48,15 @@ def fetch(resource, method: 'GET', headers: [], body: nil, redirect: 'follow', _
 
       case res
       when Net::HTTPRedirection
-        case redirect
+        case redirect.to_s
         when 'follow'
           fetch(res['Location'], method:, headers:, body:, redirect:, _redirected: true)
         when 'error'
           raise RedirectError, "redirected to #{res['Location']}"
         when 'manual'
           to_response(resource, res, _redirected)
         else
-          raise ArgumentError, "invalid redirect option: #{redirect}"
+          raise ArgumentError, "invalid redirect option: #{redirect.inspect}"
         end
       else
         to_response(resource, res, _redirected)

spec/fetch/api_spec.rb

@@ -33,7 +33,7 @@
     stub_request :post, 'http://example.com'
 
     fetch 'http://example.com', **{
-      method: 'POST',
+      method: :post,
 
       headers: {
         'Content-Type' => 'application/json'
@@ -53,11 +53,11 @@
     )
   end
 
-  example 'post form' do
+  example 'post urlencoded' do
     stub_request :post, 'http://example.com'
 
     fetch 'http://example.com', **{
-      method: 'POST',
+      method: :post,
       body:   Fetch::URLSearchParams.new(name: 'Alice')
     }
 
@@ -75,7 +75,7 @@
 
     File.open 'spec/fixtures/files/foo.txt' do |f|
       fetch 'http://example.com', **{
-        method: 'POST',
+        method: :post,
 
         headers: {
           'Content-Type' => 'multipart/form-data'
@@ -104,7 +104,7 @@
 
     stub_request :get, 'http://example.com/redirected'
 
-    res = fetch('http://example.com', redirect: 'follow')
+    res = fetch('http://example.com', redirect: :follow)
 
     expect(res.status).to eq(200)
     expect(res.redirected).to eq(true)
@@ -118,7 +118,7 @@
     })
 
     expect {
-      fetch 'http://example.com', redirect: 'error'
+      fetch 'http://example.com', redirect: :error
     }.to raise_error(Fetch::RedirectError)
   end
 
@@ -127,7 +127,7 @@
       'Location' => 'http://example.com/redirected'
     })
 
-    res = fetch('http://example.com', redirect: 'manual')
+    res = fetch('http://example.com', redirect: :manual)
 
     expect(res.status).to eq(302)
     expect(res.redirected).to eq(false)