Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of network requests during visual regression #249

Closed
andyrichardson opened this issue May 22, 2020 · 0 comments · Fixed by #294
Closed

Reduce number of network requests during visual regression #249

andyrichardson opened this issue May 22, 2020 · 0 comments · Fixed by #294
Labels
Good first issue Ideal for new contributors Maintenance Changes to the project which don't affect the end user

Comments

@andyrichardson
Copy link
Collaborator

About

During visual regression, a page load is done for each test. This should instead be one network request per fixture (portrait + landscape shouldn't require another page load).

Notes

  • To compensate for animations and such, a small delay may be required when changing the viewport.
@andyrichardson andyrichardson added Maintenance Changes to the project which don't affect the end user Good first issue Ideal for new contributors labels May 22, 2020
Rigellute added a commit that referenced this issue Aug 20, 2020
@Rigellute
Reduce number of network reqs in visual regression
310eb32 
On my machine, this cuts down the test run time from ~5 mins to ~3 mins!

Closes #249
@Rigellute Rigellute mentioned this issue Aug 20, 2020
Merged
Rigellute added a commit that referenced this issue Aug 20, 2020
@Rigellute
Reduce number of network reqs in visual regression
3cefdcb 
On my machine, this cuts down the test run time from ~5 mins to ~3 mins!

Closes #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for new contributors Maintenance Changes to the project which don't affect the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce number of network reqs in visual regression urql-graphql/urql-devtools
1 participant
@andyrichardson