Fix: Nested help command has a incorrect HelpName #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remiposo
force-pushed
the
remiposo/issue_1570
branch
from
7b207cc to
c72542b
Compare
dearchap
previously approved these changes
Nov 10, 2022
|
Thanks for the complete patch @remiposo |
dearchap
reviewed
Nov 10, 2022
| if !c.HideHelp { | ||
| if !c.HideHelpCommand && len(c.Subcommands) != 0 && c.Command(helpName) == nil { | ||
| c.Subcommands = append(c.Subcommands, helpCommandDontUse) | ||
| } |
There was a problem hiding this comment.
@remiposo can you add a test case for app -h help and app cmd -h help etc ?
|
@dearchap Thank you for your review.
|
dearchap
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
ShowCommandHelpto pass testsWhich issue(s) this PR fixes:
(REQUIRED)
Fixes #1570
Special notes for your reviewer:
(fill-in or delete this section)
In
ShowCommandHelp,len(c.Subcommands) != 0is used as the condition.. What does it mean?Even if a command has no subcommand, I think helpCommand should be added.
In fact, helpCommand can be invoked although it does not appear in help msg.
I didn't change it this time, because some of the existing test cases asserting entire help msg failed.
Testing
(fill-in or delete this section)
Test_helpCommand_HelpNametests HelpName of helpCommandTest_helpCommand_HideHelpCommandandTest_helpCommand_HideHelpFlagtest nested helpCommand callRelease Notes
(REQUIRED)