Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest compatibility #200

Merged
merged 10 commits into from
Jan 6, 2017
Merged

Pytest compatibility #200

merged 10 commits into from
Jan 6, 2017

Conversation

Peque
Copy link
Contributor

@Peque Peque commented Dec 28, 2016

These changes implement some pytest compatibility in tests. Note that, in order to keep compatibility with older test-running methods, an if __name__ == '__main__' section has been created in all test files to force execution when running tests directly with the interpreter.

This is really inconvenient and I am against it, as adding tests would imply the need to add explicit calls within that section. I guess it could be okay as a transition, though. And it is also impossible to avoid as long as pytest is not adopted as a dependency for running (adapted) dill tests. 😉

@Peque Peque mentioned this pull request Dec 28, 2016
@mmckerns
Copy link
Member

mmckerns commented Jan 6, 2017

Can you (1) update this PR, (2) delete test_file.py from this PR... or don't make it explicitly depend on the import of pytest and make sure that the .txt file artifact is deleted?

Otherwise, it's ready to PR, and I'll address the conversion of the other tests myself.

@mmckerns
Copy link
Member

mmckerns commented Jan 6, 2017

@Peque: Thanks, btw, for pushing on this and the other PRs. I'm working through it -- I will also see what I can do to address the issue that you are most interested in for pypy (i.e. #175).

@Peque
Copy link
Contributor Author

Peque commented Jan 6, 2017

@mmckerns Rebased. Removed pytest dependency and fixed test_file.py clean-up/teardown (d914795).

@mmckerns
Copy link
Member

mmckerns commented Jan 6, 2017

Thanks, I'll convert the rest to pytest from here.

@mmckerns mmckerns merged commit 9580cbc into uqfoundation:master Jan 6, 2017
@Peque Peque deleted the pytest branch January 6, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants