-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest compatibility #200
Merged
Merged
Pytest compatibility #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Can you (1) update this PR, (2) delete Otherwise, it's ready to PR, and I'll address the conversion of the other tests myself. |
Thanks, I'll convert the rest to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement some
pytest
compatibility in tests. Note that, in order to keep compatibility with older test-running methods, anif __name__ == '__main__'
section has been created in all test files to force execution when running tests directly with the interpreter.This is really inconvenient and I am against it, as adding tests would imply the need to add explicit calls within that section. I guess it could be okay as a transition, though. And it is also impossible to avoid as long as
pytest
is not adopted as a dependency for running (adapted) dill tests. 😉