On Py3, use cPickle Unpickler #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pure-Python unpickler, available as _Unpickler, uses `struct` to unpack data and the latter can also fail with `struct.error`. The default C Unpickler fails with documented and expectable UnpicklingError, and is also faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure-Python unpickler, available as
pickle._Unpickler, usesstructto unpackdata, and the latter can also fail with
struct.error. The defaultC unpickler fails with documented and expectable
UnpicklingError, andis also faster.
Dill's unpickler seems to be a very thin wrapper around pickle's unpickler, so the change is not grave in any way, just somewhat more convenient for the end user.
I'd like to help set up continuous integration build testing on Travis. What is the canonical way to run and depend on tests in the tests folder? If the files are run sequentially and all asserts pass, the build is considered passing?