Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for TinyMCE 5.x #11

Merged
merged 8 commits into from
Jun 17, 2019
Merged

Support for TinyMCE 5.x #11

merged 8 commits into from
Jun 17, 2019

Conversation

nd0ut
Copy link
Member

@nd0ut nd0ut commented Jun 11, 2019 •
edited
Loading

#10

@nd0ut nd0ut requested review from jeetiss and bautrukevich June 11, 2019 15:02
jeetiss
jeetiss approved these changes Jun 14, 2019
View reviewed changes
Copy link

@jeetiss jeetiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

bautrukevich
bautrukevich approved these changes Jun 17, 2019
View reviewed changes
Copy link

@bautrukevich bautrukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version in CHANGELOG to major and everything is ok

@nd0ut
Copy link
Member Author

nd0ut commented Jun 17, 2019

@dmitry-mukhin I made a universal plugin for both TinyMCE versions, so it will be a minor release instead of a major.

@bautrukevich yep, it will be done after the merge

@nd0ut nd0ut merged commit d6686cf into master Jun 17, 2019
@nd0ut nd0ut deleted the tinymce-5 branch June 17, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-mukhin dmitry-mukhin dmitry-mukhin left review comments

@jeetiss jeetiss jeetiss approved these changes

@bautrukevich bautrukevich bautrukevich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nd0ut @dmitry-mukhin @bautrukevich @jeetiss