Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use guzzlehttp/psr7:^2 #189

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

newtype0092
Copy link
Contributor

@newtype0092 newtype0092 commented Feb 24, 2022

Description

Add Guzzle PSR-7 version 2.x to resolve some dependency conflicts.

Thanks.

Checklist

Andrew Zhdanovskih and others added 3 commits November 15, 2021 15:41
* Test github-action run

* Add version to composer action

* Exclude local-only test group

* Add tests with php 7.4

* Experiment with version-matrix

* Exclutions for version matrix

* Add Codecov step

* Add Codecov key

* Add Codecov badge to Readme

* Extend exceptions for respect server status

* Modify Webhook API to use application/json data in requests

* Add 'signing_secret' to Webhook

* Fix types and codestyle

* Update changelog, update README

* Update CHANGELOG.md

* Update README.md

Co-authored-by: Roman Sedykh <[email protected]>
Co-authored-by: Roman Sedykh <[email protected]>
@rsedykh
Copy link
Member

rsedykh commented Mar 30, 2022

Hi. Sorry on missing out on this PR.

Have you tested backward compatibility? Will something break if you change major version?

@newtype0092
Copy link
Contributor Author

newtype0092 commented Apr 20, 2022

Sure, all unit tests passes and it works fine on my project. 😄

@Casmo
Copy link
Contributor

Casmo commented Apr 24, 2022

Would be nice!

@rsedykh
Copy link
Member

rsedykh commented Apr 25, 2022

Hey. Can you create auto-test for this PR? To run it in both environments and check that nothing brakes?

@amsoell
Copy link

amsoell commented Jul 22, 2022

Is approval of this PR on the horizon? I'm considering using Uploadcare on a production Laravel project, but the latest version of Laravel uses Guzzle PSR-7 version 2.x

@rsedykh rsedykh changed the base branch from master to develop July 22, 2022 10:37
@rsedykh rsedykh merged commit ce14ea1 into uploadcare:develop Jul 22, 2022
rsedykh added a commit that referenced this pull request Jul 22, 2022
* Allow to use guzzlehttp/psr7:^2 (#189)

Co-authored-by: Thomas Young <[email protected]>
Co-authored-by: Andrew Zhdanovskih <[email protected]>
@rsedykh
Copy link
Member

rsedykh commented Jul 22, 2022

@amsoell hi. https://github.com/uploadcare/uploadcare-php/releases/tag/v3.2.4 Thank you for using Uploadcare. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants