Update Vocalink data sets to v640 valid as of 12/10/2020 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscocardoso
requested changes
Nov 24, 2020
There was a problem hiding this comment.
Hi,
Can you please follow this example? In order to correctly update this module you need to do 3 things:
- Update the data file, which you have already done;
- Update the loadValacdos function;
- Update the docs folder with the correspondent version;
|
Hi,
As suggested, I have
1. Updated the loadValacdos function;
2. Updated the docs folder with the correspondent version;
Could you please check.
Thanks
Solanki
From: Francisco Cardoso <[email protected]>
Date: Tuesday, 24 November 2020 at 18:58
To: uphold/uk-modulus-checking <[email protected]>
Cc: Solanki Das <[email protected]>, Author <[email protected]>
Subject: Re: [uphold/uk-modulus-checking] Update Vocalink data sets to v640 valid as of 12/10/2020 (#23)
@franciscocardoso requested changes on this pull request.
Hi,
Can you please follow this example<https://github.com/uphold/uk-modulus-checking/pull/16/files>? In order to correctly update this module you need to do 3 things:
1. Update the data file, which you have already done;
2. Update the loadValacdos function;
3. Update the docs folder with the correspondent version;
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#23 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARZXDKPKZZ5DAGDL2RELRULSRP65DANCNFSM4T7KOXLA>.
|
|
Hi,
I have replaced the new file with the old version and squash the commits into one. Please find the attached screenshot of the log.
Thanks
Solanki
From: Francisco Cardoso <[email protected]>
Date: Thursday, 26 November 2020 at 17:26
To: uphold/uk-modulus-checking <[email protected]>
Cc: Solanki Das <[email protected]>, Author <[email protected]>
Subject: Re: [uphold/uk-modulus-checking] Update Vocalink data sets to v640 valid as of 12/10/2020 (#23)
You are removing the pdf file. Please replace it with the new one<https://www.vocalink.com/media/4749/vocalink-validating-account-numbers-v640.pdf> instead.
Also, please don't forget to squash the commits into one. If you are not aware how to do it you can read this<https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARZXDKLF7ONV62EPI4FJZ5DSR2FVPANCNFSM4T7KOXLA>.
|
|
Hi,
I have already made the changes requested by you. Could you please review and let me know whether any other changes are required.
Regards
Solanki.
From: Solanki Das <[email protected]>
Date: Monday, 30 November 2020 at 15:53
To: uphold/uk-modulus-checking <[email protected]>
Subject: Re: [uphold/uk-modulus-checking] Update Vocalink data sets to v640 valid as of 12/10/2020 (#23)
Hi,
I have replaced the new file with the old version and squash the commits into one. Please find the attached screenshot of the log.
Thanks
Solanki
From: Francisco Cardoso <[email protected]>
Date: Thursday, 26 November 2020 at 17:26
To: uphold/uk-modulus-checking <[email protected]>
Cc: Solanki Das <[email protected]>, Author <[email protected]>
Subject: Re: [uphold/uk-modulus-checking] Update Vocalink data sets to v640 valid as of 12/10/2020 (#23)
You are removing the pdf file. Please replace it with the new one<https://www.vocalink.com/media/4749/vocalink-validating-account-numbers-v640.pdf> instead.
Also, please don't forget to squash the commits into one. If you are not aware how to do it you can read this<https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARZXDKLF7ONV62EPI4FJZ5DSR2FVPANCNFSM4T7KOXLA>.
|
franciscocardoso
force-pushed
the
Update-Vocalink-data-sets-to-v640-valid-as-of-12/10/2020
branch
from
58bf630 to
b7a768c
Compare
franciscocardoso
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
Hi @solanki-das
I took the liberty of squashing the commits.
Thanks for your contribution and effort to keep this module up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.