Add standard and 'double alternate' methods #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return this.pickPosition(number, 'h') === (10 - remainder); | ||
| } else { |
Closed
| */ | ||
|
|
||
| loadScsubtab() { | ||
| const reader = new LineReader(`${__dirname}/data/scsubtab.txt`); |
There was a problem hiding this comment.
Can we change LineReader to a simple require?
franciscocardoso
force-pushed
the
feature/standard-and-double-alternate
branch
from
227db9c to
f96b662
Compare
|
|
||
| const accounts = { | ||
| invalid: [ | ||
| { number: '15763217', sortCode: '938063' }, |
There was a problem hiding this comment.
Change number to accountNumber?
franciscocardoso
force-pushed
the
feature/standard-and-double-alternate
branch
from
f96b662 to
9b8c02b
Compare
| describe('UkModulusChecking', () => { | ||
| describe('isValid()', () => { | ||
| accounts.invalid.forEach(function(account) { | ||
| it(`should return false if sortCode is ${account.sortCode} and number is ${account.number}`, () => { |
franciscocardoso
force-pushed
the
feature/standard-and-double-alternate
branch
8 times, most recently
from
ff6ac3a to
04a9e5c
Compare
| @@ -1,4 +1,4 @@ | |||
| FROM mhart/alpine-node:0.10 | |||
| FROM seegno/node:latest | |||
|
|
|||
| RUN adduser -S node | |||
There was a problem hiding this comment.
The seegno/node Dockerfile already adds this user.
franciscocardoso
force-pushed
the
feature/standard-and-double-alternate
branch
2 times, most recently
from
02556a8 to
09d3be4
Compare
franciscocardoso
force-pushed
the
feature/standard-and-double-alternate
branch
from
09d3be4 to
703bb08
Compare
added 3 commits
March 9, 2016 18:05
This commit adds both 'modulus weight' and 'sorting code substitution' tables along side with the validation account numbers documentation.
franciscocardoso
force-pushed
the
feature/standard-and-double-alternate
branch
from
703bb08 to
d847a5e
Compare
nunofgs
added a commit
that referenced
this pull request
Mar 9, 2016
Add standard and 'double alternate' methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are using a fork of modcheck which is a very poor implementation of the
modulus checkingalgorithm as described here.This PR adds a implementation of
modulus-checking, inspired on bazerk/uk-modulus-checking, which will help us to avoid some issues regarding correct account configuration being flagged as invalid.NOTE: All the test cases described in the documentation are covered by unit tests.